[WIP] Mutual info based feature selection#19
Open
aivarsoo wants to merge 12 commits intodwavesystems:mainfrom
Open
[WIP] Mutual info based feature selection#19aivarsoo wants to merge 12 commits intodwavesystems:mainfrom
aivarsoo wants to merge 12 commits intodwavesystems:mainfrom
Conversation
arcondello
reviewed
Apr 4, 2024
Member
arcondello
left a comment
arcondello
left a comment
There was a problem hiding this comment.
Did a quick pass, looking more closely at the logic on a second pass.
arcondello
reviewed
Apr 8, 2024
arcondello
reviewed
Apr 11, 2024
requirements.txt
Outdated
| scikit-learn==1.2.0; python_version >= '3.8' | ||
| scikit-learn==1.0.2; python_version < '3.8' | ||
| scikit-learn==1.2.1 | ||
| scipy>=1.7.3 |
Member
There was a problem hiding this comment.
Rule of thumb, we want the versions in requirements.txt to be fixed for reproducibility, but as wide as possible in setup.cfg for flexibility.
| dwave.plugins | ||
| dwave.plugins.sklearn | ||
| python_requires = >=3.7 | ||
| python_requires = >=3.8 |
Member
There was a problem hiding this comment.
We should note this in the release notes. E.g. Drop support for Python 3.7. or Upgrade your python to 3.8+. We no longer support python 3.7 and below..
added 7 commits
April 16, 2024 15:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding another algorithm for feature selection based on mutual information. The algorithms are based on these publications:
[1] Peng, F. Long, and C. Ding. Feature selection based on mutual information criteria of max-dependency,
max-relevance, and min-redundancy. IEEE Transactions on pattern analysis and machine intelligence,
27(8):1226–1238, 2005.
[2] X. V. Nguyen, J. Chan, S. Romano, and J. Bailey. Effective global approaches for mutual information
based feature selection. In Proceedings of the 20th ACM SIGKDD international conference on
Knowledge discovery and data mining, pages 512–521. ACM, 2014.